Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy tests. Looks like the tests are error order sensitive #856

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Fix mypy tests. Looks like the tests are error order sensitive #856

merged 1 commit into from
Oct 30, 2021

Conversation

euresti
Copy link
Contributor

@euresti euresti commented Oct 30, 2021 •
edited
Loading

Fixes #855

Pull Request Check List

This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do. If your pull request is a documentation fix or a trivial typo, feel free to delete the whole thing.

  • Added tests for changed code.
  • New features have been added to our Hypothesis testing strategy.
  • Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • ...and used in the stub test file tests/typing_example.py.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changes to the signature of @attr.s() have to be added by hand too.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives. Find the appropriate next version in our __init__.py file.
  • Documentation in .rst files is written using semantic newlines.
  • Changes (and possible deprecations) have news fragments in changelog.d.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

@euresti euresti mentioned this pull request Oct 30, 2021
Closed
@euresti euresti requested a review from hynek October 30, 2021 15:19
hynek
hynek approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@hynek hynek merged commit 82ab0c1 into python-attrs:main Oct 30, 2021
thetorpedodog pushed a commit to thetorpedodog/attrs that referenced this pull request Nov 1, 2021
@euresti @thetorpedodog
Fix mypy tests. Looks like the tests are error order sensitive (pytho…
c5effaf 
…n-attrs#856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hynek hynek hynek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_mypy fails
2 participants
@euresti @hynek